Talk:Musical instrument - Revision history

Umbire the Phantom: circling back

2024-06-05T23:02:58Z

circling back

← Older revision		Revision as of 23:02, 5 June 2024
Line 4:		Line 4:
	<references/>		<references/>
	::Sounds like the latter article just needs updating accordingly, then (which it likely did anyway). --[[User:Umbire the Phantom\|Umbire the Phantom]] ([[User talk:Umbire the Phantom\|talk]]) 18:12, 9 April 2023 (UTC)		::Sounds like the latter article just needs updating accordingly, then (which it likely did anyway). --[[User:Umbire the Phantom\|Umbire the Phantom]] ([[User talk:Umbire the Phantom\|talk]]) 18:12, 9 April 2023 (UTC)

			:Coming back to this, I feel like we can possible merge [[atonal instrument]] and [[tonal instrument]] into this article as subsections and have links to those redirect here where necessary. It's not high-priority but would be nice in the long run. --[[User:Umbire the Phantom\|Umbire the Phantom]] ([[User talk:Umbire the Phantom\|talk]]) 23:02, 5 June 2024 (UTC)

Umbire the Phantom: reply

2023-04-09T18:12:57Z

← Older revision		Revision as of 18:12, 9 April 2023
Line 2:		Line 2:
	The [[tin whistle]] article calls it an atonal instrument, but the [[atonal instrument]] article contradicts that and says it's ''not'' an instrument. As far as I know, NetHack has no formal classification of "musical instrument". There's the informal definition of "an elf might start with one", but that of course excludes the magical ones. On the basis that they exist to make noise, I think the whistles should be considered atonal instruments, and we can add notes to the appropriate articles that elves never start with them. --[[User:Darth l33t\|Darth l33t]] ([[User talk:Darth l33t\|talk]]) 23:41, 8 April 2023 (UTC)		The [[tin whistle]] article calls it an atonal instrument, but the [[atonal instrument]] article contradicts that and says it's ''not'' an instrument. As far as I know, NetHack has no formal classification of "musical instrument". There's the informal definition of "an elf might start with one", but that of course excludes the magical ones. On the basis that they exist to make noise, I think the whistles should be considered atonal instruments, and we can add notes to the appropriate articles that elves never start with them. --[[User:Darth l33t\|Darth l33t]] ([[User talk:Darth l33t\|talk]]) 23:41, 8 April 2023 (UTC)
	:I was thinking that the best formal definition is what items call <code>do_play_instrument()</code> when applied, but bells and whistles don't use that.{{refsrc\|src/apply.c\|3723-L3733\|nethack=3.6.7}} Then I found that a comment in the object definitions actually does consider tin whistles and magic whistles to be instruments.{{refsrc\|src/objects.c\|685-L701\|nethack=3.6.7}} [[User:Cathartes\|Cathartes]] ([[User talk:Cathartes\|talk]]) 00:13, 9 April 2023 (UTC)		:I was thinking that the best formal definition is what items call <code>do_play_instrument()</code> when applied, but bells and whistles don't use that.{{refsrc\|src/apply.c\|3723-L3733\|nethack=3.6.7}} Then I found that a comment in the object definitions actually does consider tin whistles and magic whistles to be instruments.{{refsrc\|src/objects.c\|685-L701\|nethack=3.6.7}} [[User:Cathartes\|Cathartes]] ([[User talk:Cathartes\|talk]]) 00:13, 9 April 2023 (UTC)
			<references/>
			::Sounds like the latter article just needs updating accordingly, then (which it likely did anyway). --[[User:Umbire the Phantom\|Umbire the Phantom]] ([[User talk:Umbire the Phantom\|talk]]) 18:12, 9 April 2023 (UTC)

Cathartes: /* Definition of instrument */ source code considers whistles to be instruments

2023-04-09T00:14:19Z

Definition of instrument: source code considers whistles to be instruments

← Older revision		Revision as of 00:14, 9 April 2023
Line 1:		Line 1:
	==Definition of instrument==		==Definition of instrument==
	The [[tin whistle]] article calls it an atonal instrument, but the [[atonal instrument]] article contradicts that and says it's ''not'' an instrument. As far as I know, NetHack has no formal classification of "musical instrument". There's the informal definition of "an elf might start with one", but that of course excludes the magical ones. On the basis that they exist to make noise, I think the whistles should be considered atonal instruments, and we can add notes to the appropriate articles that elves never start with them. --[[User:Darth l33t\|Darth l33t]] ([[User talk:Darth l33t\|talk]]) 23:41, 8 April 2023 (UTC)		The [[tin whistle]] article calls it an atonal instrument, but the [[atonal instrument]] article contradicts that and says it's ''not'' an instrument. As far as I know, NetHack has no formal classification of "musical instrument". There's the informal definition of "an elf might start with one", but that of course excludes the magical ones. On the basis that they exist to make noise, I think the whistles should be considered atonal instruments, and we can add notes to the appropriate articles that elves never start with them. --[[User:Darth l33t\|Darth l33t]] ([[User talk:Darth l33t\|talk]]) 23:41, 8 April 2023 (UTC)
			:I was thinking that the best formal definition is what items call <code>do_play_instrument()</code> when applied, but bells and whistles don't use that.{{refsrc\|src/apply.c\|3723-L3733\|nethack=3.6.7}} Then I found that a comment in the object definitions actually does consider tin whistles and magic whistles to be instruments.{{refsrc\|src/objects.c\|685-L701\|nethack=3.6.7}} [[User:Cathartes\|Cathartes]] ([[User talk:Cathartes\|talk]]) 00:13, 9 April 2023 (UTC)

Darth l33t: definition

2023-04-08T23:42:31Z

definition

New page

==Definition of instrument==
The [[tin whistle]] article calls it an atonal instrument, but the [[atonal instrument]] article contradicts that and says it's ''not'' an instrument. As far as I know, NetHack has no formal classification of "musical instrument". There's the informal definition of "an elf might start with one", but that of course excludes the magical ones. On the basis that they exist to make noise, I think the whistles should be considered atonal instruments, and we can add notes to the appropriate articles that elves never start with them. --[[User:Darth l33t|Darth l33t]] ([[User talk:Darth l33t|talk]]) 23:41, 8 April 2023 (UTC)