User:Ilmari Karonen/fixDoubleRedirects - Revision history

Ilmari Karonen: fix option desc and year in copyright statement

2011-02-02T21:30:27Z

fix option desc and year in copyright statement

Ilmari Karonen: fix svn link in description text

2011-02-02T21:11:58Z

fix svn link in description text

Ilmari Karonen: more fixes, now with actual testing :)

2011-02-02T20:56:58Z

more fixes, now with actual testing :)

Ilmari Karonen: fix it right this time, I hope

2011-02-02T20:48:05Z

fix it right this time, I hope

Ilmari Karonen: fix implode() params

2011-02-02T20:44:17Z

fix implode() params

Ilmari Karonen: try this, paxed

2011-02-02T20:39:32Z

try this, paxed

New page

This is a (hopefully) MW 1.16 -compatible version of [http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/maintenance/fixDoubleRedirects.php&view=markup]. Remember to create [[MediaWiki:double-redirect-fixed-maintenance]] (as e.g. "<nowiki>Fixing double redirect from [[$1]] to [[$2]].</nowiki>") before running this script.

<source lang=PHP><?php
/**
* Script to fix double redirects.
*
* Copyright (C) 2010 Ilmari Karonen <nospam@vyznev.net>
* http://www.mediawiki.org/
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
* @author Ilmari Karonen <nospam@vyznev.net>
* @ingroup Maintenance
*/

require_once( dirname( __FILE__ ) . '/Maintenance.php' );

class FixDoubleRedirects extends Maintenance {
public function __construct() {
parent::__construct();
$this->mDescription = "Script to fix double redirects";
$this->addOption( 'async', 'Don\'t fix anything directly, just add queue the jobs' );
$this->addOption( 'title', 'Fix only redirects pointing to this page', false, true );
$this->addOption( 'dry-run', 'Perform a dry run, fix nothing' );
}

public function execute() {
$async = $this->getOption( 'async', false );
$dryrun = $this->getOption( 'dry-run', false );
$title = $this->getOption( 'title' );

if ( isset( $title ) ) {
$title = Title::newFromText( $title );
if ( !$title || !$title->isRedirect() ) {
$this->error( $title->getPrefixedText() . " is not a redirect!\n", true );
}
}

$dbr = wfGetDB( DB_SLAVE );

$pageTable = $dbr->tableName( 'page' );
$redirTable = $dbr->tableName( 'redirect' );

$fields = array(
'pa.page_namespace AS pa_namespace',
'pa.page_title AS pa_title',
'pb.page_namespace AS pb_namespace',
'pb.page_title AS pb_title',
);
$conds = array(
'rd_from = pa.page_id',
'rd_namespace = pb.page_namespace',
'rd_title = pb.page_title',
"pb.page_is_redirect = '1'",
);

if ( isset( $title ) ) {
$conds['pb.page_namespace'] = $title->getNamespace();
$conds['pb.page_title'] = $title->getDBkey();
}
// TODO: support batch querying

$sql = implode( ' ', 'SELECT', $fields, "FROM $redirTable, $pageTable AS pa, $pageTable AS pb WHERE", $conds );

$res = $dbr->query( $sql, __METHOD__ );

if ( !$res->numRows() ) {
$this->output( "No double redirects found.\n" );
return;
}

$jobs = array();
$n = 0;
foreach ( $res as $row ) {
$titleA = Title::makeTitle( $row->pa_namespace, $row->pa_title );
$titleB = Title::makeTitle( $row->pb_namespace, $row->pb_title );

$job = new DoubleRedirectJob( $titleA, array( 'reason' => 'maintenance', 'redirTitle' => $titleB->getPrefixedDBkey() ) );

if ( !$async ) {
$success = ( $dryrun ? true : $job->run() );
if ( !$success ) {
$this->error( "Error fixing " . $titleA->getPrefixedText() . ": " . $job->getLastError() . "\n" );
}
} else {
$jobs[] = $job;
// FIXME: hardcoded constant 10000 copied from DoubleRedirectJob class
if ( count( $jobs ) > 10000 ) {
$this->queueJobs( $jobs, $dryrun );
$jobs = array();
}
}

if ( ++$n % 100 == 0 ) {
$this->output( "$n...\n" );
}
}

if ( count( $jobs ) ) {
$this->queueJobs( $jobs, $dryrun );
}
$this->output( "$n double redirects processed.\n" );
}

protected function queueJobs( $jobs, $dryrun = false ) {
$this->output( "Queuing batch of " . count( $jobs ) . " double redirects.\n" );
Job::batchInsert( $dryrun ? array() : $jobs );
}
}

$maintClass = "FixDoubleRedirects";
require_once( DO_MAINTENANCE );
</source>

← Older revision		Revision as of 21:11, 2 February 2011
Line 1:		Line 1:
−	This is a (hopefully) MW 1.16 -compatible version of [http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/maintenance/fixDoubleRedirects.php&view=markup]. Remember to create [[MediaWiki:double-redirect-fixed-maintenance]] (as e.g. "<nowiki>Fixing double redirect from [[$1]] to [[$2]].</nowiki>") before running this script.	+	This is a (hopefully) MW 1.16 -compatible version of [http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/maintenance/fixDoubleRedirects.php?view=markup maintenance/fixDoubleRedirects.php]. Remember to create [[MediaWiki:double-redirect-fixed-maintenance]] (as e.g. "<nowiki>Fixing double redirect from [[$1]] to [[$2]].</nowiki>") before running this script.

	<source lang=PHP><?php		<source lang=PHP><?php

@@ Line 75: / Line 75: @@
 		// TODO: support batch querying
-		$sql = implode(	' ', array( 'SELECT', $fields, "FROM $redirTable, $pageTable AS pa, $pageTable AS pb WHERE", $conds ) );
+		$sql = "SELECT " . implode( ' ', $fields ) . " FROM $redirTable, $pageTable AS pa, $pageTable AS pb WHERE " . implode( ' ', $conds );
 		$res = $dbr->query( $sql, __METHOD__ );

@@ Line 5: / Line 5: @@
   * Script to fix double redirects.
+  *
-  * Copyright (C) 2010 Ilmari Karonen <nospam@vyznev.net>
+  * Copyright (C) 2011 Ilmari Karonen <nospam@vyznev.net>
   * http://www.mediawiki.org/
+  *
@@ Line 34: / Line 34: @@
 		parent::__construct();
 		$this->mDescription = "Script to fix double redirects";
-		$this->addOption( 'async', 'Don\'t fix anything directly, just add queue the jobs' );
+		$this->addOption( 'async', 'Don\'t fix anything directly, just queue the jobs' );
 		$this->addOption( 'title', 'Fix only redirects pointing to this page', false, true );
 		$this->addOption( 'dry-run', 'Perform a dry run, fix nothing' );

@@ Line 66: / Line 66: @@
 			'rd_namespace = pb.page_namespace',
 			'rd_title = pb.page_title',
-			"pb.page_is_redirect = '1'",
+			'pb.page_is_redirect' => 1,
 		);
@@ Line 75: / Line 75: @@
 		// TODO: support batch querying
-		$sql = "SELECT " . implode( ' ', $fields ) . " FROM $redirTable, $pageTable AS pa, $pageTable AS pb WHERE " . implode( ' ', $conds );
+		$sql = "SELECT " . implode( ',', $fields ) .
 		$res = $dbr->query( $sql, __METHOD__ );