Difference between revisions of "Talk:Atonal instrument"

From NetHackWiki
Jump to navigation Jump to search
(I don't really see why whistles are "not instruments")
 
(on the other hand, elven players don't get whistles)
Line 2: Line 2:
  
 
I'm not convinced that it makes much sense to single out whistles as “not instruments”. While whistles are not handled by music.c, neither are bells. Also, there aren't really any useful properties shared by atonal instruments, so I'm not sure what excluding whistles is supposed to achieve. I don't really care ''that'' much; it just seems odd to see whistles explicitly listed as not instruments when this classification has no real basis in the source code, and no real effect. -- [[User:Killian|Killian]] 12:23, 10 July 2008 (UTC)
 
I'm not convinced that it makes much sense to single out whistles as “not instruments”. While whistles are not handled by music.c, neither are bells. Also, there aren't really any useful properties shared by atonal instruments, so I'm not sure what excluding whistles is supposed to achieve. I don't really care ''that'' much; it just seems odd to see whistles explicitly listed as not instruments when this classification has no real basis in the source code, and no real effect. -- [[User:Killian|Killian]] 12:23, 10 July 2008 (UTC)
 +
 +
:Hmm, I had a thought: elven players are generated with a random non-magical instrument, and while bells and leather drums are eligible, tin whistles are not. So I guess there's at least one useful distinction after all. -- [[User:Killian|Killian]] 12:34, 10 July 2008 (UTC)

Revision as of 12:34, 10 July 2008

Instruments and non-instruments

I'm not convinced that it makes much sense to single out whistles as “not instruments”. While whistles are not handled by music.c, neither are bells. Also, there aren't really any useful properties shared by atonal instruments, so I'm not sure what excluding whistles is supposed to achieve. I don't really care that much; it just seems odd to see whistles explicitly listed as not instruments when this classification has no real basis in the source code, and no real effect. -- Killian 12:23, 10 July 2008 (UTC)

Hmm, I had a thought: elven players are generated with a random non-magical instrument, and while bells and leather drums are eligible, tin whistles are not. So I guess there's at least one useful distinction after all. -- Killian 12:34, 10 July 2008 (UTC)