View source for W343-3

{|style="width:100%"
|-valign="top"
|'''W343-3''' designates a [[bugs in NetHack 3.4.3#W343-3|bug]] that affects the [[Microsoft Windows]] version of [[NetHack 3.4.3]].  It is fixed in [[NetHack 3.6.0]].  The bug is listed as:

<poem style="border: 1px dashed #2f6fab;background-color: #f9f9f9; padding:0.5em">
<tt>Under the Polish version of Windows 2000 SP4, screen output with a raster font shows wrong characters for many dungeon features</tt></poem>

__TOC__
|{{patch
 |name=Win32 locales fix
 |author=Ray Chason
 |download=http://nhpatchdb.alt.org/?download=313
 |bilious=313
}}
|}

== Nature of the bug ==

The bug has been reported on [http://groups.google.com/group/rec.games.roguelike.nethack/browse_thread/thread/4ba778741135464e Polish] and Russian editions of Windows 2000 and on a [http://groups.google.com/group/rec.games.roguelike.nethack/browse_thread/thread/8eea5ab560b85b7b Czech] version of Windows XP.  It has been [http://groups.google.com/group/rec.games.roguelike.nethack/browse_frm/thread/6bd4af64d16878f6 duplicated] on an American Windows XP by changing a language setting.  A [http://amiro.republika.pl/nethack/screen1.png screenshot] is available.

Bug W343-3 really comprises two distinct and unrelated bugs.  One is a simple character set issue:  many non-USA PCs are configured with different character sets, and seven symbols may look different.  This issue is more fully detailed in the [[IBMgraphics]] article.

The more serious bug is that some characters appear as strange symbols or blank squares.  This is not actually a bug in NetHack, but in Windows.  The rest of this article will deal with this bug.

== Cause of the bug ==

The bug is a flaw in the Windows WriteConsoleOutputCharacterA API.  When its configured code page is other than 437 or 850, many non-[[ASCII]] characters can show up incorrectly.

The bug occurs when four conditions are met:

* The version of Windows is Windows NT or one of its descendants, no later than Windows 8.1.  The bug is confirmed to exist on Windows 2000, Windows XP, Windows Vista, Windows 7, Windows 8 and Windows 8.1. It is confirmed to be fixed on Windows 10 (but see the note below on Windows 10).
* The built-in command shell window is used. Alternate command shell windows are available; [http://cmder.net/ Cmder], in particular, is confirmed ''not'' to have the bug.
* A bitmap font, rather than Lucida Console, is selected.
* The command shell is running in a window, rather than full screen.  Windows Vista and later do not support full screen mode in the console, and so this item will always be true for those versions of Windows.
* The language for non-Unicode programs is set to one whose OEM [[wikipedia:code page|code page]] is anything ''other'' than [[wikipedia:code page 437|437]] or  [[wikipedia:code page 850|850]].  Basically this means any East European language, whether it uses Greek, Cyrillic or Latin writing.

No API other than WriteConsoleOutputCharacterA is known to be affected.  In particular, the Unicode variant WriteConsoleOutputCharacterW works correctly.

=== Windows 10 ===

The Windows terminal program changed in Windows 10. The changed fixed the original W343-3 problem, but certain characters on the [[Rogue level]] may not display correctly. Specifically, the characters that have code points less than 0x20 display as empty boxes. See [[IBMgraphics]] for more details.

This bug appears when the terminal program is ''not'' in legacy mode and when a TrueType font is selected.

This bug is only loosely related to W343-3, but the fix in the code is the same. All users of Windows 10 running NetHack 3.4.3, regardless of locale, can benefit from the W343-3 patch.

== Versions affected ==

[[NetHack 3.4.3]] is known to have this bug.  Because [[NetHack 3.1.1]] through [[NetHack 3.1.3|3.1.3]] also use the flawed API, it is likely that they have it as well.  [[NetHack 3.2.0]] through [[NetHack 3.4.2|3.4.2]] use different APIs, and do not have this bug.

The [[Curses interface]] is not affected, even when linked with PDCurses for the Win32 console, because PDCurses does not uses the offending API.

== Patch ==

The bug is fixed in [[NetHack 3.6.0]]. A [[patch]] is available to fix this bug in [[NetHack 3.4.3]]; but no binaries or variants other than [[Spanish NetHack]] are known to incorporate it.

The patch fixes the API issue by detecting when it is running on an NT-based version of Windows, and using the Unicode API instead, avoiding the Windows bug.  It fixes the character set issue as well (see [[IBMgraphics]]) by allowing less-extensive variants of IBMgraphics to be set, avoiding the characters that can vary among code pages.

The patch was posted to [[rec.games.roguelike.nethack]] as four articles:

* [http://groups.google.com/group/rec.games.roguelike.nethack/browse_thread/thread/65e249e2c8e48115 Part 1] describes the API issue and provides detailed instructions to duplicate it, and a small test program to demonstrate the bug.
* [http://groups.google.com/group/rec.games.roguelike.nethack/browse_thread/thread/2c4e9391e6da19bc Part 2] describes the character set issue.
* [http://groups.google.com/group/rec.games.roguelike.nethack/browse_thread/thread/1634242b9cc429e2 Part 3] contains the patch itself.
* [http://groups.google.com/group/rec.games.roguelike.nethack/browse_thread/thread/8abe3cd0e85e5a09 Part 4] is a description of each change the patch makes.

The [[NetHack Patch Database]] has a simpler form of this patch, that works around the faulty API but does not alter the IBMgraphics, [http://nhpatchdb.alt.org/?313 here].  This patch also fixes [[W343-4]].

{{noversion}}<!--historic-->
[[Category:Bugs]]