Difference between revisions of "Talk:Patching"

From NetHackWiki
Jump to navigation Jump to search
Line 20: Line 20:
 
What's the patchfile? What does CR-LF mean? What does "line ending" mean? What option "--binary"? What the hell is going on here? I know that the majority of NetHack players are Computer geeks, but you don't have to make it even harder for normal people than it already is! <BR>
 
What's the patchfile? What does CR-LF mean? What does "line ending" mean? What option "--binary"? What the hell is going on here? I know that the majority of NetHack players are Computer geeks, but you don't have to make it even harder for normal people than it already is! <BR>
 
[[User:MC-Dirty|MC-Dirty]] 12:27, 31 July 2009 (UTC)
 
[[User:MC-Dirty|MC-Dirty]] 12:27, 31 July 2009 (UTC)
 +
 +
==Great tutorial, but...===
  
 
I've followed the compile article to the letter and vanilla NH complies just fine. I've followed this one as well, but I get this message when I try to compile:
 
I've followed the compile article to the letter and vanilla NH complies just fine. I've followed this one as well, but I get this message when I try to compile:

Revision as of 17:32, 24 May 2011

Can someone please expand on this? As a windoze programmer I have never used patch and am trying to apply the vs2005 patch and it keeps failing and I do not understand why...

missing header for context diff at line 13 of patch

I assume you're speaking of this patch. I unpacked nethack's sources, and downloaded the vc2005-file in the source root directory, and typed
patch -p0 < vc2005

in the command line, which seems to work ok for me, but I'm on linux... Haven't tried compiling nethack with that patch either. --Paxed 14:59, 19 July 2007 (UTC)

Using cygwin helps. I tried using a windows binary of patch, but that didn't work too well. I eventually installed cygwin and used that to apply a patch (menucolors) and it worked.Addps4cat 13:31, 7 September 2007 (UTC)

Now what?

Well everything went all right, except that none of the patches still took any effect. I concluded that they'd have no way of knowing where my SLASH'EM is, so I copy-pasted all them files to the source directory. Still no effect.

What did I do wrong?

What?

I'd like to use this moment to say: WHAT?! This instruction is completely incomprehensible!
"note: On MS-Windows, the patchfile must be a text file, i.e. CR-LF must be used as line endings. A file with LF may give the error: "Assertion failed, hunk, file patch.c, line 343," unless the option '--binary' is given."
What's the patchfile? What does CR-LF mean? What does "line ending" mean? What option "--binary"? What the hell is going on here? I know that the majority of NetHack players are Computer geeks, but you don't have to make it even harder for normal people than it already is!
MC-Dirty 12:27, 31 July 2009 (UTC)

Great tutorial, but...=

I've followed the compile article to the letter and vanilla NH complies just fine. I've followed this one as well, but I get this message when I try to compile: Linking.... o/wintty.o: In function `get_menu_coloring': c:\nh343\src/../win/tty/wintty.c:1146: undefined reference to `_imp__regexec' o/options.o: In function `add_menu_coloring': c:\nh343\src/../src/options.c:1071: undefined reference to `_imp__regcomp' c:\nh343\src/../src/options.c:1074: undefined reference to `_imp__regerror' o/save.o: In function `free_menu_coloring': c:\nh343\src/../src/save.c:969: undefined reference to `_imp__regfree' collect2: ld returned 1 exit status mingw32-make: *** [../binary/NetHack.exe] Error 1

Can anyone help? I'm trying to make a menucolors+statuscolors version. The one I found linked on the patch database wasn't compiled with autopickup exceptions... -Tekuromoto 17:31, 24 May 2011 (UTC)