Difference between revisions of "User talk:Bulwersator/UnNetHackPlus bug tracking"

From NetHackWiki
Jump to navigation Jump to search
(C343-302)
(C343-302: reply, thanks)
Line 20: Line 20:
 
http://nethackwiki.com/wiki/Read.c#line501
 
http://nethackwiki.com/wiki/Read.c#line501
 
it should be possible that the player doesn't forget anything when the "count * percent" is smaller than 50. Dancing with a mind flayer seems to prove that. The bug description is of course again quite unhelpful and even wrong. This is only true for flayers as there forget_objects(25) is used. If you are using scrolls of amnesia, you don't forget 2 discoveries as rn2(25) is used and that never will produce 25. --[[User:Bhaak|Bhaak]] ([[User talk:Bhaak|talk]]) 10:10, 22 April 2013 (UTC)
 
it should be possible that the player doesn't forget anything when the "count * percent" is smaller than 50. Dancing with a mind flayer seems to prove that. The bug description is of course again quite unhelpful and even wrong. This is only true for flayers as there forget_objects(25) is used. If you are using scrolls of amnesia, you don't forget 2 discoveries as rn2(25) is used and that never will produce 25. --[[User:Bhaak|Bhaak]] ([[User talk:Bhaak|talk]]) 10:10, 22 April 2013 (UTC)
 +
:Thanks, I [http://nethackwiki.com/mediawiki/index.php?title=Bugs_in_NetHack_3.4.3&diff=84258&oldid=84234 added] to [[bugs]] page comment "Thanks to [[read.c#line501]] player doesn't forget anything when the "count * percent" is smaller than 50. In other words player that knows identify of single object will never loose memory of it via mind flayer attack.". [https://github.com/Bulwersator/UnNetHackPlus/commit/1eca66fbdca7c224d45c255ef6729a889832964e My fix] is to forget (count * percent) / 100 objects with (count * percent)%100 percent chance for additional one [[User:Bulwersator|Bulwersator]] ([[User talk:Bulwersator|talk]]) 18:36, 22 April 2013 (UTC)

Revision as of 18:36, 22 April 2013

C342-54

The bug, unless I (and Grunt) misunderstand it, is that a statue of a unique monster, if left in a bones file, may be turned into the unique monster using stone to flesh or a statue trap. This is inconsistent as normally, some of these monsters are removed from bones, including their corpses (which could be revived).

There is also the possiblity of generating the unique monster (say, Medusa on her level), then using stone to flesh on the statue to have two instances of the "unique" monster simultaneously present in your game. If you then turn both of these into statues and leave them in a bones file and that bones file is loaded, that game may have three Medusas, etc.

I'm not sure why you "see no need" for GruntHack's fix (which actually only seems to fix it for specific monsters); it's consistent with wished-for statues of unique monsters, which will also turn into a doppelganger. —bcode talk | mail 16:40, 23 March 2013 (UTC)

  • Hm. Is there any way to check whatever something is a monster X or a chameleon/doppelganger pretending to be a monster X? Wand of probing is not able to do this Bulwersator (talk) 17:11, 23 March 2013 (UTC)
There are rings of protection from shape changers, but they will not show you the monster whose form the shapechanger would normally assume.
Thanks! Bulwersator (talk) 16:57, 27 March 2013 (UTC)
(By the way, the usual way to indent replies on this wiki is using :, not *. Using : on talk pages will be highlighted.) —bcode talk | mail 17:19, 23 March 2013 (UTC)
OK, I will try to remember this Bulwersator (talk) 16:57, 27 March 2013 (UTC)
I thought that wished-for statue and stoned unique monster behaves in the same way - now I see what is happening. Bulwersator (talk) 16:57, 27 March 2013 (UTC)
" including their corpses (which could be revived)" according to my testing corpses of uniques are not removed and I see no code that is trying to do this (just made game with two Medusas) Bulwersator (talk) 07:57, 31 March 2013 (UTC)
I see that now, too – I must have thought of something else there, or simply misremembered. Sorry about that. —bcode talk | mail 08:08, 31 March 2013 (UTC)

C343-302

"Amnesia of object discoveries may forget to forget one thing." Looking at the function forget_objects() http://nethackwiki.com/wiki/Read.c#line501 it should be possible that the player doesn't forget anything when the "count * percent" is smaller than 50. Dancing with a mind flayer seems to prove that. The bug description is of course again quite unhelpful and even wrong. This is only true for flayers as there forget_objects(25) is used. If you are using scrolls of amnesia, you don't forget 2 discoveries as rn2(25) is used and that never will produce 25. --Bhaak (talk) 10:10, 22 April 2013 (UTC)

Thanks, I added to bugs page comment "Thanks to read.c#line501 player doesn't forget anything when the "count * percent" is smaller than 50. In other words player that knows identify of single object will never loose memory of it via mind flayer attack.". My fix is to forget (count * percent) / 100 objects with (count * percent)%100 percent chance for additional one Bulwersator (talk) 18:36, 22 April 2013 (UTC)