User:Furey/My TODOs

From NetHackWiki
Jump to navigation Jump to search

When I edit articles, I find a lot of other issues. If you fix any of these, feel free to edit this page. Or even if you just make adjacent changes, or know something that would help.

Sweeps

articles with {{nethack-360}}

https://nethackwiki.com/wiki/Category:Nethack-360_articles

As of June 20, 2024: 104 articles.

Review each article. Most of these articles have a lot of deferred maintenance. Bring them up to date, then bump the version template to {{nethack-367}}.

articles with unversioned function templates

https://nethackwiki.com/wiki/Category:Pages_with_unversioned_Function_templates

Most of these will get updated by the nethack-360 etc updates. As of June 14 2024, 89 of these.

articles with unversioned refsrc templates

https://nethackwiki.com/wiki/Category:Pages_with_unversioned_Refsrc_templates

When refsrc quietly moved from 3.4.3 to 3.6.1, a lot of these quietly broke.

As of June 17 2024, 256 of these.

redlinks to pages

 https://nethackwiki.com/index.php?title=Special:WantedPages&limit=5000&offset=0
 https://nethackwiki.com/index.php?title=Special:WantedPages&limit=5000&offset=5000

As of June 17, 2024: 5682 hits.

Finished one pass.

More things to do:

  • Create redirects for messages based on User:Zuzak/Messages.
  • Use LinklessExists in language template to kill about 1400 missing translation pages.
  • Use LinklessExists in object template.
  • Make some lists by variant and ask for help.

articles with http://nethack.org links

Change http://nethack.org to https://nethack.org everywhere. http://nethack.org puts up warning messages in red letters and that is an unpleasant user experience.

I used to want to fix all http -> https. However, as of June 2024 many sites still do not work with https, and I haven't seen actual problems from our use of http. If you are overhauling an article with http feel free to test https and if it works, go ahead with the change.

Update: 14 links remaining

Delete redirects of the form [[Foo.h]] and [[Foo.c]]

Part of https://nethackwiki.com/wiki/User:Furey/References_to_source_code .

Many of these started as redirects to 3.4.3 source code and then quietly switched to 3.6.1 source code. This leaves the callers expecting 3.4.3 referring to the wrong version.

Look at https://nethackwiki.com/index.php?title=Source:NetHack_3.4.3/src/allmain.c&oldid=84998 and every other 3.4.3 source file. They contain "link to me" instructions that actually link to 3.6.1!

In progress

  • Sweeping 3.4.3 source files to fix the broken "link here" instructions.
    • *.h done.
    • *.des done.

Todo

  • Sweep WLH for the bare-filename articles and fix fixable stuff.
    • References from Source:NetHack_3.4.3 to bare-filename articles are wrong because 3.6.1.
  • https://nethackwiki.com/wiki/User:PsyMar/Source_Structs
    • left a friendly note on the discussion page, but last activity of this user was in 2012, so not expecting a response
    • just let the redlinks happen?
    • me or an admin send notice, wait 30 days, then put ... on the page, maybe a cat with a box?
  • actually delete all the redirects

Redirect all in-game messages to an appropriate article (low priority)

Home page links to https://nethackwiki.com/wiki/NetHackWiki:Current_projects which says:

 Redirect all in-game messages to an appropriate article

https://nethackwiki.com/wiki/User:Zuzak/Messages lists about 1,029 messages. Many of them are redlinked, so this project will fix a lot of redlinks, too.

Update: right after I dived in with some commits for this, an admin changed the policy. This project has been suspended.

unused interwiki links

https://nethackwiki.com/wiki/Special:Interwiki

As of June 20 2024, we have 647 interwiki links.

In June 2024 I discovered that three [[meatball:xxx]] links from NetHackWiki:policy were pointing to an ad farm for Vietnamese casinos and sports gambling sites. We fixed them right away. I called this the Meatball Crisis.

Also wikia.com is a reputable site but they serve a lot of ads which leads to a poor reader experience. It would be good to replace those with links to wikipedia or to independent wikis. After all, NetHackWiki is an independent wiki.

https://nethackwiki.com/wiki/User:Furey has an interwiki link to [furey:xyzzy]. This shows up as a redlink and is listed in https://nethackwiki.com/index.php?title=Special:WantedPages&limit=5000&offset=0 . So if we delete an interwiki prefix that is currently in use, the page will have a redlink, and we can see the redlink in WantedPages. (However there might be caching issues.)

I have a sweep in progress where I post one letter at a time to NetHackWiki:Community_Portal and an admin (currently Umbire) is deleting them.

It would be good to make a NetHackWiki page with an intro to interwiki, a list of interwiki links, and instructions to sync the list with the interwiki prefix table, then about once per month go through the list and look for any sites that have disappeared or shifted to ad farms.

interwiki whitelist (partial)

Here are some prefixes I have found in use:

  • clubpenguin
  • commons
  • dnd
  • emacswiki
  • gameinfo
  • google
  • gta
  • m
  • manual
  • meatball
  • mediawikiwiki
  • mediazilla
  • memoryalpha
  • metawiki
  • metawikimedia
  • metawikipedia
  • mw
  • php
  • roguebasin
  • s
  • w
  • wiki
  • wikia
  • wikibooks
  • wikicities
  • wikimedia
  • wikinfo
  • wikipedia
  • wikt
  • wiktionary

gameinfo

User:Furey/History_of_gameinfo

Done:

  • deleted template::gameinfo2
  • changed all users of template::gameinfo to use direct gamicus links
  • marked template:gameinfo and its png with a delete tag
  • marked interwiki link gameinfo for preservation

Todo:

  • wait for admin to delete files marked for deletion
    • on hold because of bluelink from archived community portal page
    • check results for gameinfo again

articles with missing directory in refsrc

https://nethackwiki.com/wiki/Category:Pages_with_missing_directory_in_Refsrc

Produces 404 on GitHub.

As of June 17, 2024: 73 hits.

redlinks from spammer welcome pages (low priority)

https://nethackwiki.com/wiki/User_talk:118.40.201.62

 Hi, welcome to NetHackWiki! Thanks for your edit to the Hi all, I want to say something about me and how I found this site. page.

Now the wantedpages report has a line for Hi all, I want to say something about me and how I found this site..

I estimate there are 10 to 20 of these, out of 6000 total wantedpages. But it's healthy for me to flush garbage when I see it, instead of working around it. So I need to write a policy proposal, then get consensus, then blank these talk pages and mark them {{delete}}. As soon as the page blank hits they will be off the wantedpages report. Then an admin can review the deletion requests through the regular process.

source links that are meant to be 3.4.3, but resolve to 3.6.1

Example:

Source:NetHack 3.4.3/src/save.c says:

 Below is the full text to src/save.c from NetHack 3.4.3. To link to a particular line, write [[save.c#line123]], for example.

And then Save.c resolves to 3.6.1.

Pages like https://nethackwiki.com/index.php?title=Save.c&redirect=no are broken by design. They start as 3.4.3, and then someone edits the page to point to 3.6.1, and then every page that relies on it is quietly pointing to a bogus line in an unwanted version.

I need to figure out all these versionless source file pages and then chase their "what links here" and then turn them into refsrc's where the caller specifies a version and the version doesn't shift as helper pages and templates shift and then put {{delete}} tags on the broken pages.

tnnt articles that need tiles

github tnnt has tiles.

https://github.com/tnnt-devteam/tnnt/blob/master/win/share/monsters.txt

https://github.com/tnnt-devteam/tnnt/blob/master/win/share/objects.txt

As far as I can tell, there is no custom tile for Really Cool Shirt.

Templates

template:Languages/Lang

https://www.mediawiki.org/wiki/Help:Extension:ParserFunctions#ifexist_and_wanted_pages

(There's a lot of user complaints about this behavior.)

languages/lang uses #ifexist. That is why our unwanted pages report has about 1400 /de, /fi, /ko, /ru, etc.

Update: Ion Frigate made LinklessExists, let's rock and roll!

Test lab:

 Look in wanted pages and search for "Furey says".
 Furey says hello giant ant, nice of you to exist
 Furey says goodbye agony aunt, sorry you do not exist


template:Monster

Refline parameter assumes NetHack 3.6.1. Reference parameter maybe could take a versioned srcref. Dunno what variants are doing today.

template:variant-36X and template:variant-37X

We have template:variant-343. Look into creating variant-36X, variant-37X.

Articles

@Play (low priority)

[@Play] has 89 http: links, of which 79 are gamesetwatch.com and need archive captures. Or maybe we don't need to be indexing someone's compilation page, just point to an external collection.

artifact

Perhaps merge intelligent artifact into artifact?

Big duplicate table for artifact weapon damage.

I agree with the suggestion to merge the pages, and have placed a merge notice on the intelligent artifact page --Aximili (talk) 00:14, 15 June 2024 (UTC)

beartrap

The trap article refers to here, so beartrap should be about both beartrap objects and bear trap trap type.

Article messages need to acknowledge "the trap" / "your trap" distinction. So does main body. I believe every trap that hero sets is a "your trap" but I've never checked.

comestible

Article should describe throwing comestibles to monsters. It's a critical early-game strategy.

Article should describe splatter foods (eggs, cream pies, melons). Then other articles should refer to the section on splatter foods. Right now, at least 6 articles have the list of splatter foods: little dog, dog, large dog, kitten, house cat, large cat.

covetous

Per discussion on Talk:Master Kaen, covetous could use a note about how fast covetous monsters can warp and attack, backed by some source diving and wizard mode testing.

damage

Take the source dive from double damage, walk it again, fill out more parts that I skipped and hurried over.

Discussion opened on talk:damage.

After 3.7.0 someone has to re-do the source dive anyways.

damage type

astral vision blocks blindness

History changes incorporated.

drain energy (monster attack)

Need new article. Copy from drain life (monster attack).

foocubus

Someone marked the article 3.6.7 but it still talks about SEDUCE as a compile-time option. In the same paragraph with a 3.6.7 refsrc that refers to SEDUCE as a sysconf action.

Free

Article needs refresh.

Updated some glaring bits: sourceforge -> github. 3.4.3 -> 3.6.7. Added some srcref's. Checked that legal language matches the source code.

Did not copy edit the whole article.

Next: final review.

guidebook

A previous editor just version-bumped from 3.4.3 to 3.6.0 without reviewing. Left a bit about compile-time Elbereth hanging. More important, the set of options changes with every release. Gotta walk the article and compare it vs the 3.6.7 guidebook.

Healing potions

Mostly repeats older articles. Move unique info into potion articles, then blank for deletion.

interwiki link for wikipedia

We should change it from http to https. Others can change too. Test some more because it takes an admin to make or revert this change. Also might help to do more of Phase 1 on interwiki links so we can see what is left over.

List of qt_xpms.h images

Version-blurred. Both 3.4.3 and 3.6.1 link to the same page, although 3.6.1 has different images than 3.4.3. Likely fix: List of qt_xpms.h images (3.4.3) and List of qt_xmps.h images (3.6.1).

mercenary and Yendorian army

These articles have a lot of parallel duplication. I marked them both with {{merge}}.

nethack.alt.org (low priority)

"Players with saved games of NetHack 3.6.2, NetHack 3.6.3, NetHack 3.6.4, NetHack 3.6.5, or NetHack 3.6.6 may finish out their games, but no player may start a new game with these versions."

As of June 17, 2024:

!lg * name role version version<3.6.6 max=deathdate

 furey: name,role,version,deathdate: 1) merlektest,Rog,3.6.4,20240521;  2) greydog,Sam,3.6.2,20240519;  3) nortimer,Wiz,3.6.2,20240429;  4) gandalftotalbro,Cav,3.6.4,20240422;  5) ckorsgaard,Val,3.6.2,20240421;  6) Nikita2001,Val,3.6.2,20240403;  7) ASC1I,Rog,3.6.2,20240402;  8) timosarkar,Val,3.6.2,20240327;  9) flandre,Sam,3.6.2,20240324;  10) Eben,Val,3.6.2,20240322

NetHackWiki:Community Portal

Audit this page and its archives for shitty ad site takeovers. Check its archive pages too. Okay if outlinks break, as long as they are not evil.

persistent level

Rogue did have a save feature, which did embed the current dungeon level in the save file. Actually, Rogue implemented the save feature by crudely dumping everything in memory from version to sbrk(0), with no regard to which part of memory contains the current dungeon level. (Carefully read the save.c file of Rogue 3.6 for details.)

Sounds plausible, but I cannot get the source to verify.

https://www.tuhs.org/cgi-bin/utree.pl?file=2.11BSD/src/games/rogue/save.c claims to be 2.11 BSD and shows an sccsid from 1987. This file uses a conventional write-variables, read-variables appproach.

Public server

Needs ongoing monitoring. Has had several updates in the past three years.

symset

This article has the same big-ass list as Custom map symbols. Here it is in a three-column table, with ascii defaults and descriptions. Also, the Guidebook has the same big-ass list, in three-column form, as well!

Custom map symbols is sorted in source code order. symset is sorted in grouped order. The Guidebook is sorted in alphabetical order.

Right now my idea is to table-ize Custom map symbols, add in table headings from somewhere. Then have symset point to it. That way symset will document code behavior, and Custom map symbols will just have a big table.

Talk:Main Page/Archive1

Found this during the meatball crisis. [[wikicities:xxx]] link, does not work. Several wikia links. Did not notice any domains taken over by ads (beyond the usual wikia stuff that is).

This will be a good page for finding bad interwiki links. The article doesn't have to work, it just has to not link to bad ads.

theft (attack)

Needs bunch of work. First, there are three damage types: AD_SITM, AD_SEDU (which is a bad name), and AD_SAMU. So we need two or three pages. Second, these are damage types, not attack types, although that's probably livable. Third, AD_SAMU needs its own page, not mixed in with AD_SITM. And AD_SAMU needs a history note that 3.4.3 behavior is "steal your quest artifact" and 3.6.7 behavior is "steal any quest artifact". It's a big difference between 3.4.3 and 3.6.7 and comes up a lot on IRC.

Zen

Add more variants. TNNT (the game) offers Zen.

Done 2024-06-24.

Ideas for more work

Historical

Idea: we should make a historical namespace or historical category or something. Slap one tag on an article and get a box that says "this article is primarily of historical interest. It is not updated for new versions of NetHack. External links may not work properly." Set the cutoff at information prior to NetHack 3.4.0. Allow maintenance so editors can update things as necessary, especially external links.